Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chart demos on “Basic charts” page/ Add new chart demos and mini cards under each remaining demo #2175

Closed
10 tasks done
mjabbink opened this issue Mar 13, 2021 · 11 comments

Comments

@mjabbink
Copy link
Contributor

mjabbink commented Mar 13, 2021

Basic charts page updates

https://www.carbondesignsystem.com/data-visualization/basic-charts

  • Add Lollipop to anchor link list
  • Add Lollipop demo (one variant only)
  • Add Bullet to anchor link list
  • Add Bullet demo (one variant only)
  • Add Boxplot to anchor link list
  • Add Boxplot demo (one variant only)

Anchor link list in alphabetical order:
Area
Bar (vertical)
Bar (horizontal)
Boxplot
Bubble
Bullet
Combo
Donut
Gauge
Line
Lollipop
Meter
Pie
Radar
Scatter
Step

  • Remove all additional demo variants so only 1 demo per chart type shows up on the page (Anchor links equal one demo)

  • Add Storybook icons to standard resource card and mini cards (attached below)*

  • Add number of variants in the mini card*

Chart types page updates

  • add illustrations for new charts to chart types page (Jeannie give svgs to Eliad)
@mjabbink
Copy link
Contributor Author

FYI @jeanservaas

@mjabbink
Copy link
Contributor Author

mjabbink commented Mar 13, 2021

Expected anchor list:
Screen Shot 2021-03-31 at 4 38 20 PM

@mjabbink mjabbink changed the title Remove chart demos on “Basic charts” page Remove chart demos on “Basic charts” page/ Add mini cards under each remaining demo Mar 31, 2021
@mjabbink
Copy link
Contributor Author

mjabbink commented Mar 31, 2021

New approach:
— Mini card should link to corresponding chart in Carbon Charts Storybook.
— Mini card should include the number of variants and storybook icon (included below in thread)

Screen Shot 2021-03-31 at 4 32 35 PM

@mjabbink
Copy link
Contributor Author

  • Update icon in resource card and Mini resource card to use “Storybook” icon.

Screen Shot 2021-03-31 at 4 21 15 PM

Screen Shot 2021-03-31 at 4 21 25 PM

@mjabbink
Copy link
Contributor Author

storybook_icon.svg.zip

@mjabbink mjabbink changed the title Remove chart demos on “Basic charts” page/ Add mini cards under each remaining demo Remove chart demos on “Basic charts” page/ Add demos and mini cards under each remaining demo Mar 31, 2021
@mjabbink mjabbink changed the title Remove chart demos on “Basic charts” page/ Add demos and mini cards under each remaining demo Remove chart demos on “Basic charts” page/ Add new chart demos and mini cards under each remaining demo Mar 31, 2021
@mjabbink
Copy link
Contributor Author

mjabbink commented Mar 31, 2021

Basic_charts_no_grid

@theiliad
Copy link
Member

pt. 1 of this work is finished

Just merged a PR in Carbon Charts which re-organizes the demos to follow this format carbon-design-system/carbon-charts#992

@mjabbink Also I think we need to rename the cards to say 20 more demos rather than 20 variants since not all the other demos are variants of the chart

@mjabbink
Copy link
Contributor Author

@theiliad Go for “20 more demos” — makes sense to me.

@mjabbink
Copy link
Contributor Author

  • Add Circle pack demo to Complex charts page.

  • Add thumbnail/mini to the Chart types page @jeanservaas to supply image

@theiliad
Copy link
Member

  • Add Circle pack demo to Complex charts page.
  • Add thumbnail/mini to the Chart types page @jeanservaas to supply image

already being addressed here #2300

@mjabbink
Copy link
Contributor Author

@eliad correct me if I’m wrong but I think all of these issues were addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants