Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rollup): update cwc rollup config #9854

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix(rollup): update cwc rollup config #9854

merged 2 commits into from
Jan 4, 2023

Conversation

kennylam
Copy link
Member

Description

Update carbon-web-components rollup config to suppress the following warning:

@rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.

Changelog

Changed

  • set preventAssignment: true

@kennylam kennylam requested a review from a team as a code owner December 22, 2022 15:37
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 22, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9854/index.html

Built with commit: ec6f17a0dbfa02f14d638d5fac1302f418b8dfc5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 22, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9854/index.html

Built with commit: ec6f17a0dbfa02f14d638d5fac1302f418b8dfc5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 22, 2022 •
edited
Loading

Deploy preview created for package "Carbon Web Components":
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9854/index.html

Built with commit: ec6f17a0dbfa02f14d638d5fac1302f418b8dfc5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 22, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9854/index.html

Built with commit: ec6f17a0dbfa02f14d638d5fac1302f418b8dfc5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 22, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9854/index.html

Built with commit: ec6f17a0dbfa02f14d638d5fac1302f418b8dfc5

emyarod
emyarod approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 3, 2023
@kodiakhq kodiakhq bot merged commit ca282b3 into carbon-design-system:main Jan 4, 2023
@kennylam kennylam deleted the fix/rollup-replace-options branch January 4, 2023 13:55
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@kennylam
fix(rollup): update cwc rollup config (carbon-design-system#9854)
94a4e31 
### Description

Update `carbon-web-components` rollup config to suppress the following warning:
```
@rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
```

### Changelog

**Changed**

- set `preventAssignment: true` 

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@kennylam
fix(rollup): update cwc rollup config (carbon-design-system#9854)
0e7a8f6 
### Description

Update `carbon-web-components` rollup config to suppress the following warning:
```
@rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
```

### Changelog

**Changed**

- set `preventAssignment: true` 

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennylam @ibmdotcom-bot @emyarod