Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): apply carbon element decorator for accordion skeleton #11989

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Aug 26, 2024

Related Ticket(s)

Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}}

Description

Adopter running into issues with accordion component when using the accordion in multiple libraries as the accordion-skeleton component is not using the carbonElement decorator.

This PR also fixes a couple smaller issues with missing the select import in the pagination/index.js file and missing stylesheet import for the dropdown stackblitz example

Changelog

Changed

  • accordion-skeleton to use custom carbonElement decorator
  • add select import in the pagination/index.js file
  • include stylesheet import in the dropdown example

@annawen1 annawen1 requested a review from a team as a code owner August 26, 2024 13:27
@annawen1 annawen1 requested review from IgnacioBecerra and sangeethababu9223 and removed request for a team August 26, 2024 13:27
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 26, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 26, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 26, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 26, 2024

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Aug 26, 2024
@kodiakhq kodiakhq bot merged commit dfdc39b into carbon-design-system:main Aug 26, 2024
13 of 20 checks passed
@annawen1 annawen1 deleted the fix/accordion-custom-element branch August 26, 2024 17:02
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hey there! This issue/pull request was referenced in recently released v2.12.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants