Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdn): emit the CSS grid classes in a new artifact cssgrid.css #11626

Merged
merged 4 commits into from
Mar 15, 2024
Merged

fix(cdn): emit the CSS grid classes in a new artifact cssgrid.css #11626

merged 4 commits into from
Mar 15, 2024

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Mar 8, 2024

Related Ticket(s)

No related issue

Description

This includes a new cssgrid.css output available via CDN, as the current grid.css emits the flex grid.

Changelog

New

  • cssgrid.css output (CDN)

Changed

  • Updated build configuration output for CDN

@jeffchew jeffchew requested a review from a team as a code owner March 8, 2024 18:58
@jeffchew jeffchew requested review from IgnacioBecerra and sangeethababu9223 and removed request for a team March 8, 2024 18:58
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 8, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11626/index.html

Built with commit: 3712f5b853ccdedbe0e8dc79ce38edf3c0f0b2ef

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 8, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11626/index.html

Built with commit: 3712f5b853ccdedbe0e8dc79ce38edf3c0f0b2ef

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 8, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11626/index.html

Built with commit: 3712f5b853ccdedbe0e8dc79ce38edf3c0f0b2ef

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 8, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11626/index.html

Built with commit: 3712f5b853ccdedbe0e8dc79ce38edf3c0f0b2ef

annawen1
annawen1 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annawen1 annawen1 added Ready to merge Label for the pull requests that are ready to merge dev Needs some dev work labels Mar 15, 2024
@annawen1 annawen1 merged commit 98afd6a into carbon-design-system:main Mar 15, 2024
9 of 12 checks passed
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 20, 2024
@jeffchew @kennylam
@annawen1 @kodiakhq
fix(cdn): emit the CSS grid classes in a new artifact cssgrid.css (ca…
79e794b 
…rbon-design-system#11626)

* fix(cdn): emit the CSS grid classes in a new artifact cssgrid.css

* fix(grid-cdn): add path to root node_modules

---------

Co-authored-by: kennylam <[email protected]>
Co-authored-by: Anna Wen <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.6.0.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.6.0.

kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@jeffchew @kennylam
@annawen1 @kodiakhq
fix(cdn): emit the CSS grid classes in a new artifact cssgrid.css (ca…
fafc87d 
…rbon-design-system#11626)

* fix(cdn): emit the CSS grid classes in a new artifact cssgrid.css

* fix(grid-cdn): add path to root node_modules

---------

Co-authored-by: kennylam <[email protected]>
Co-authored-by: Anna Wen <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffchew @ibmdotcom-bot @annawen1 @kennylam