Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pagination): mark selected option in page-sizes-select component #10884

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix(pagination): mark selected option in page-sizes-select component #10884

merged 2 commits into from
Aug 31, 2023

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Aug 25, 2023 •
edited
Loading

Related Ticket(s)

Closes #10553
https://jsw.ibm.com/browse/ADCMS-3821

Description

Fixes a bug where the initial value of the page-size attribute on the <bx-pagination> component previously did not set the correct <option> element within the <bx-page-sizes-select> component.

Changelog

Changed

  • Updated the slotchange handler for the <bx-page-sizes-select> component to set the selected attribute when applicable.

Testing Instructions

  • Navigate to Pagination > Default story
  • Enter a different value for "Number of rows per page (page-size)", using one of the other values in the dropdown, eg. 20 or 30
  • Click the "Open canvas in new tab" button, this will initiate the story with the set value for page-size to test the bug
  • Should see the value you set for the items per page drop down.

@m4olivei m4olivei requested a review from a team as a code owner August 25, 2023 18:24
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10884/index.html

Built with commit: d795118561f0717aae5455d4040f535df9be710d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10884/index.html

Built with commit: d795118561f0717aae5455d4040f535df9be710d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10884/index.html

Built with commit: d795118561f0717aae5455d4040f535df9be710d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10884/index.html

Built with commit: d795118561f0717aae5455d4040f535df9be710d

emyarod
emyarod approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Aug 31, 2023
@m4olivei
Copy link
Contributor Author

Thanks @emyarod ! I've labeled as Ready to merge and updated with the main branch.

@kodiakhq kodiakhq bot merged commit ec3e4cf into carbon-design-system:main Aug 31, 2023
@m4olivei m4olivei deleted the fix/pagination-story-v1 branch August 31, 2023 14:54
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@m4olivei
fix(pagination): mark selected option in page-sizes-select component (c…
48a2ead 
…arbon-design-system#10884)

### Related Ticket(s)

Closes carbon-design-system#10553
https://jsw.ibm.com/browse/ADCMS-3821

### Description

Fixes a bug where the initial value of the `page-size` attribute on the `<bx-pagination>` component previously did not set the correct `<option>` element within the `<bx-page-sizes-select>` component.

### Changelog

**Changed**

- Updated the `slotchange` handler for the `<bx-page-sizes-select>` component to set the `selected` attribute when applicable.

### Testing Instructions

* Navigate to Pagination > Default story
* Enter a different value for "Number of rows per page (page-size)", using one of the other values in the dropdown, eg. 20 or 30
* Click the "Open canvas in new tab" button, this will initiate the story with the set value for `page-size` to test the bug
* Should see the value you set for the items per page drop down.
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@m4olivei
fix(pagination): mark selected option in page-sizes-select component (c…
53e469c 
…arbon-design-system#10884)

### Related Ticket(s)

Closes carbon-design-system#10553
https://jsw.ibm.com/browse/ADCMS-3821

### Description

Fixes a bug where the initial value of the `page-size` attribute on the `<bx-pagination>` component previously did not set the correct `<option>` element within the `<bx-page-sizes-select>` component.

### Changelog

**Changed**

- Updated the `slotchange` handler for the `<bx-page-sizes-select>` component to set the `selected` attribute when applicable.

### Testing Instructions

* Navigate to Pagination > Default story
* Enter a different value for "Number of rows per page (page-size)", using one of the other values in the dropdown, eg. 20 or 30
* Click the "Open canvas in new tab" button, this will initiate the story with the set value for `page-size` to test the bug
* Should see the value you set for the items per page drop down.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
bug Something isn't working package: carbon web components Ready to merge Label for the pull requests that are ready to merge v1
Projects
None yet
Milestone
No milestone
3 participants
@m4olivei @ibmdotcom-bot @emyarod