Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multi-select): move filterable attribute out of scope for styles #10608

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix(multi-select): move filterable attribute out of scope for styles #10608

merged 1 commit into from
Jun 27, 2023

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Jun 27, 2023 •
edited
Loading

Related Ticket(s)

Filterable doesn't work in multi-select#9729

Description

The filterable option for multi-select doesn't appear to work because the styles to hide the options are not coming through when pulling in the package externally outside of storybook.

You can see it currently doesn't appear to filter in this codesandbox: https://codesandbox.io/p/sandbox/dazzling-burnell-4my6t8

Moving the selector out of the scope should fix this.

Changelog

Changed

  • use separate selector rule when referencing the filterable attribute

@annawen1 annawen1 marked this pull request as ready for review June 27, 2023 17:09
@annawen1 annawen1 requested a review from a team as a code owner June 27, 2023 17:09
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10608/index.html

Built with commit: c141060304089cb58a4f12f7a5b1ac81e5b94311

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10608/index.html

Built with commit: c141060304089cb58a4f12f7a5b1ac81e5b94311

IgnacioBecerra
IgnacioBecerra approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks anna!!

@IgnacioBecerra IgnacioBecerra added Ready to merge Label for the pull requests that are ready to merge package: carbon web components labels Jun 27, 2023
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10608/index.html

Built with commit: c141060304089cb58a4f12f7a5b1ac81e5b94311

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10608/index.html

Built with commit: c141060304089cb58a4f12f7a5b1ac81e5b94311

emyarod
emyarod approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@IgnacioBecerra IgnacioBecerra merged commit 1c1cf35 into carbon-design-system:release/v1.48.0 Jun 27, 2023
@annawen1 annawen1 deleted the fix/multi-select-filterable branch July 24, 2023 15:11
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@annawen1
fix(multi-select): move filterable attribute out of scope for styles (c…
0fc1468 
…arbon-design-system#10608)
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@annawen1
fix(multi-select): move filterable attribute out of scope for styles (c…
8b53a47 
…arbon-design-system#10608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@emyarod emyarod emyarod approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annawen1 @ibmdotcom-bot @emyarod @IgnacioBecerra