Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checkbox): set relative position #10333

Merged
merged 4 commits into from
Apr 12, 2023
Merged

fix(checkbox): set relative position #10333

merged 4 commits into from
Apr 12, 2023

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Apr 12, 2023

Related Ticket(s)

#10311

Description

This PR adds a position rule to the checkbox container to avoid absolutely positioning the input in the top left corner of the document. I couldn't pinpoint the exact commit which caused this change but it does not seem to originate from our repo and maybe related to upstream style changes that we are importing

Changelog

Changed

  • checkbox position rule

@emyarod emyarod requested a review from a team as a code owner April 12, 2023 19:23
@emyarod emyarod requested review from kennylam and RichKummer April 12, 2023 19:23
@emyarod emyarod requested a review from ariellalgilmore April 12, 2023 19:23
@emyarod emyarod changed the base branch from main to release/v1.46.0 April 12, 2023 19:29
@kennylam kennylam added Ready to merge Label for the pull requests that are ready to merge package: carbon web components and removed package: carbon web components labels Apr 12, 2023
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10333/index.html

Built with commit: f57cf9e819bb00d9e0b3d305058d03f97015cc43

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10333/index.html

Built with commit: f57cf9e819bb00d9e0b3d305058d03f97015cc43

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10333/index.html

Built with commit: f57cf9e819bb00d9e0b3d305058d03f97015cc43

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10333/index.html

Built with commit: f57cf9e819bb00d9e0b3d305058d03f97015cc43

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10333/index.html

Built with commit: f57cf9e819bb00d9e0b3d305058d03f97015cc43

@ariellalgilmore ariellalgilmore merged commit 8f10b78 into carbon-design-system:release/v1.46.0 Apr 12, 2023
@emyarod emyarod deleted the 10311-fix/checkbox-input-position branch April 17, 2023 16:10
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@emyarod @ibmdotcom-bot
fix(checkbox): set relative position (carbon-design-system#10333)
929c635 
Co-authored-by: Carbon for IBM.com Bot <[email protected]>
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@emyarod @ibmdotcom-bot
fix(checkbox): set relative position (carbon-design-system#10333)
e0a0ef6 
Co-authored-by: Carbon for IBM.com Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emyarod @ibmdotcom-bot @kennylam @ariellalgilmore