Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): styles with sass upgrade #10237

Merged
merged 6 commits into from
Mar 21, 2023
Merged

fix(modal): styles with sass upgrade #10237

merged 6 commits into from
Mar 21, 2023

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

N/A

Description

With the sass upgrade we need to pull in aditional modal styes when modal is open

Changelog

Changed

  • opacity: 1;
    visibility: inherit; to modal styles

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner March 16, 2023 15:05
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10237/index.html

Built with commit: c99959318ceef01ee81f7c048e9f10cb330277c3

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2023 •
edited
Loading

Deploy preview created for package Carbon:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10237/index.html

Built with commit: c99959318ceef01ee81f7c048e9f10cb330277c3

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10237/index.html

Built with commit: c99959318ceef01ee81f7c048e9f10cb330277c3

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10237/index.html

Built with commit: c99959318ceef01ee81f7c048e9f10cb330277c3

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 16, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10237/index.html

Built with commit: c99959318ceef01ee81f7c048e9f10cb330277c3

RichKummer
RichKummer approved these changes Mar 16, 2023
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that this PR seems to remove the transition animation for when the modal appears/disappears from the screen. I approved in case this is a separate issue!

Screen.Recording.2023-03-16.at.11.51.45.AM.mov

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Mar 20, 2023
@ariellalgilmore ariellalgilmore merged commit 46993a9 into carbon-design-system:release/v1.45.0 Mar 21, 2023
@ariellalgilmore ariellalgilmore deleted the fix/modal-styles-sass branch March 21, 2023 16:00
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10237/index.html

Built with commit: c99959318ceef01ee81f7c048e9f10cb330277c3

@RichKummer RichKummer mentioned this pull request Mar 24, 2023
Closed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@ariellalgilmore @annawen1
fix(modal): styles with sass upgrade (carbon-design-system#10237)
7bc7773 
* fix(modal): styles with sass upgrade

* fix(modal): add transition styles

* fix(modal): remove modal trigger button from story

---------

Co-authored-by: Anna Wen <[email protected]>
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@ariellalgilmore @annawen1
fix(modal): styles with sass upgrade (carbon-design-system#10237)
596e401 
* fix(modal): styles with sass upgrade

* fix(modal): add transition styles

* fix(modal): remove modal trigger button from story

---------

Co-authored-by: Anna Wen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichKummer RichKummer RichKummer approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariellalgilmore @ibmdotcom-bot @RichKummer @annawen1