Skip to content

Commit

Permalink
fix(leadspace): in storybook adding long copy to copy knob led to but…
Browse files Browse the repository at this point in the history
…ton being clipped away (#12117)

### Related Ticket(s)

[ADCMS-6827](https://jsw.ibm.com/browse/ADCMS-6827)

### Description

Adding **long** text to the leadspace copy knob leads to clipping the text & CTAs.

Issue:
![image](https://github.com/user-attachments/assets/7f51a789-33a8-463f-a408-b5d8628c7a93)


Fixed:
![image](https://github.com/user-attachments/assets/bcd9b23c-593c-480a-b145-9864408d2b99)


### NOTE
There's an apparent bug in all heading/title knobs in all components, when you try to modify it, we get the below error.
I've been trying to debug this error, but with @m4olivei 's help, we found out it's an issue that's been sitting there for a while now, so It would just be very time consuming for the tiny fix that was the original scope of this ticket
![example3](https://github.com/user-attachments/assets/6c613264-6bc8-4bcf-9bed-7c5a8350f236)
  • Loading branch information
bruno-amorim authored Nov 22, 2024
1 parent 5908e7c commit 86647b3
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions packages/styles/scss/components/leadspace/_leadspace.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright IBM Corp. 2016, 2023
* Copyright IBM Corp. 2016, 2024
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
Expand Down Expand Up @@ -513,8 +513,8 @@ $btn-min-width: 26;

:host(#{$c4d-prefix}-leadspace)[size='super'] {
@include breakpoint(lg) {
.#{$c4d-prefix}--leadspace__overlay {
block-size: 40rem;
.#{$c4d-prefix}--leadspace--content__container {
min-block-size: 38rem;
}
}

Expand All @@ -527,8 +527,8 @@ $btn-min-width: 26;

:host(#{$c4d-prefix}-leadspace)[size='medium'] {
@include breakpoint(lg) {
.#{$c4d-prefix}--leadspace__overlay {
block-size: 30rem;
.#{$c4d-prefix}--leadspace--content__container {
min-block-size: 28rem;
}
}

Expand All @@ -548,7 +548,7 @@ $btn-min-width: 26;
:host(#{$c4d-prefix}-leadspace)[size='short'] {
@include breakpoint(lg) {
.#{$c4d-prefix}--leadspace__overlay {
block-size: 20rem;
min-block-size: 20rem;
}
}

Expand Down Expand Up @@ -578,8 +578,8 @@ $btn-min-width: 26;

:host(#{$c4d-prefix}-leadspace)[size='tall'] {
@include breakpoint(lg) {
.#{$c4d-prefix}--leadspace__overlay {
block-size: 35rem;
.#{$c4d-prefix}--leadspace--content__container {
min-block-size: 33rem;
}
}

Expand Down

0 comments on commit 86647b3

Please sign in to comment.