Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11 [tooltip] update styles to accomodate new toggletip component #483

Closed
kingtraceyj opened this issue Nov 22, 2021 · 2 comments
Closed
Assignees
Labels
kit: sketch version: 11 Issues pertaining to Carbon v11

Comments

@kingtraceyj
Copy link
Member

kingtraceyj commented Nov 22, 2021

Update tooltip symbol

  • remove interactive elements inside tooltip
  • check caret sizing to make sure it's right
@laurenmrice
Copy link
Member

laurenmrice commented Jan 7, 2022

Standard tooltip

  • Made new group and item symbols.
  • Renamed "Interactive tooltip" group and item symbols to "Toggletip" and moved to the Toggletip component.

Icon button tooltip

  • Item: Adjusted padding in tooltip around text to be 2px instead of 3px.
  • Group: Adjusted padding between icon and tooltip to be 4px instead of 8px.
  • Question: Should we use the real button component in this instance or keep it the same for now? It will break peoples symbols if we change it. We decided to leave it as is but change it in the Figma kits since they are still so new.

Definition tooltip

  • Didn't change anything.

  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme

@laurenmrice laurenmrice added kit: sketch version: 11 Issues pertaining to Carbon v11 labels Jan 7, 2022
@laurenmrice
Copy link
Member

Updated! Will be available in the next Sketch kit update. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kit: sketch version: 11 Issues pertaining to Carbon v11
Projects
None yet
Development

No branches or pull requests

2 participants