-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v11: (type styles) add new expressive styles label-02, caption-02, helper-text-02 #439
Comments
I'm working on Gray 10 theme now and this is how the structure looks like (image below). All styles colors are linked to V2 library. Expressive styles are in a separate folder, but inside of it there is no distinction between fluid (lg, max, etc.) and regular expressive styles (the new ones we just added). Luckily the names of the styles make the fluid ones being "grouped" (by alphabetical order) together. Should it stay this way? |
I did add it, let me know what's the best approach here. |
Does
That's a good question.. I had origininally imagined In looking at the structure image above, I'm realizing the @laurenmrice would love to hear your thoughts! |
It means IDL v2
Sure, I will add it.
Regarding current structure (on the image above) additional grouping fluid styles isn't necessary I think and doing so would just add another level in Sketch to go through — we all know this is not the best experience :) Regarding expressive / productive vs fluid / fixed — it all depends what's most important to emphasise. If we choose the latter then designers working with Carbon for product might have the wrong impression that it is ok to use these expressive new styles in product UIs. I'm curious what you do think on how to approach this. |
@mariuszmickiewicz @oliviaflory I just got on a call with dotcom peeps to talk this through. We have landed on the following structure: ● First level-All body type styles with suffix ⃝ Second level-Productive headings --> 1-7 headings will be listed out. ▪️Third level-Each breakpoint bucket will include fluid
|
All themes done. |
I believe
Thank you so much 💯 🙏. I am going to keep this open for now still because we are going to talk about this again as a larger group today to discuss the placement of expressive-headings-01 and -02 as well as the names of the productive and expressive buckets. Will let you know what the outcome is. |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
@mariuszmickiewicz Ok! After further discussion, we have made additional changes to the text styles. The changes include new tokens, removal of some tokens and name changes of existing tokens. Here is the list: New tokenslabel-02 legal-01 legal-02 Deleted tokenscaption-01 *Deleting caption tokens in favor of label-01 and label-02. Name changes
Structure in kitThis is the folder/bucket structure they should be in:
|
Seems like
are in both expressive and productive groups. I'm just making sure this is intentional? If so I will try to make the duplicates in such a way, that currently used styles of each type are untouched - stay connected to peoples' documents. For example current Deleted styles |
Is the same true for respective -02 styles (which we originally added in this thread)? I don't see them on the newest list so I assume |
Which color tokens are required for Seems like |
|
I believe it's intentional because Product uses both, and expressive will likely utilize both. |
Final list of type tokens*All values for type tokens match the updated type guidance for v11 Utility styles
Body styles
Fixed heading styles
Fluid heading styles
Fluid display styles
Deprecated styles
*In favor of label-01 and label-02
Added and updated! Will be available in the next Sketch kit update. 🎉 |
Detailed description
Describe in detail the issue you're having. Please include whether or not this is part of Sketch Libraries or the larger Sketch Kit file.
The Carbon for IBM.com team and all dotcom designers will be transitioning to use the Carbon design kits as we integrate the Expressive variants needed into Carbon. The designers will need access to the new styles added to accommodate expressive experience needs, which were previously provided through the Carbon Expressive kits maintained by Carbon for IBM.com team.
Add the new expressive type styles to the Carbon design kits. I figure it would be good to have the color tokens match between the corresponding productive/expressive styles, but open to feedback.
caption-02
Color tokens:
label-02
Color tokens:
helper-text-02
Color tokens:
Add in all themes
v10 kit
Carbon for IBM.com will use the v10 kit until we have a migration plan for v11
New type styles added to enable expressive experiences
The type styles were added to the Type package
Carbon for IBM.com
Additional information
Add labels
Please choose the appropriate label(s) from our existing label list to ensure that your issue is properly categorized (i.e.use the
libraries
label for any issue relating to the Carbon Sketch Library). This will help us to better understand and address your issue.The text was updated successfully, but these errors were encountered: