Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small toggles, off state #344

Closed
heatherco opened this issue Jul 7, 2020 · 5 comments
Closed

Small toggles, off state #344

heatherco opened this issue Jul 7, 2020 · 5 comments
Assignees

Comments

@heatherco
Copy link

Sketch libraries grey 10 and white: the small toggles in off state are not consistent with the big toggle versions. Also at their current state in the sketch file, they do not meet the 3:1 accessibility ratio.

Screen_Shot_2020-07-07_at_11_12_02_AM

@aagonzales
Copy link
Member

Hi @heatherco, this is a Sketch bug. The code has the correct 3:1 contrast. Kit issues can be submitted to the kit repo. I'll transfer this issue over.

Original issue where the color was update: carbon-design-system/carbon#3614

@aagonzales aagonzales transferred this issue from carbon-design-system/carbon Jul 22, 2020
@aagonzales
Copy link
Member

Check to make sure all toggle states in all themes have the updated values
carbon-design-system/carbon#3614

@stale
Copy link

stale bot commented Aug 21, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Aug 21, 2020
@laurenmrice
Copy link
Member

laurenmrice commented Aug 25, 2020

  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme

@laurenmrice laurenmrice self-assigned this Aug 25, 2020
@laurenmrice
Copy link
Member

Fixed! will be in next kit update 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants