Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution: Selectable Tag #33

Open
AT-public opened this issue Jul 24, 2019 · 3 comments
Open

Contribution: Selectable Tag #33

AT-public opened this issue Jul 24, 2019 · 3 comments

Comments

@AT-public
Copy link

Component Name

Selectable Tag

Reason & Research for this change? 

  • Selectable tag is a unique component in PAL but it's not Health specific so do we want it to be in Carbon?
  • Visually using tag styling to give a checkbox/radio button experience
  • We often use this component to visually represent selected filter criteria

Screen Shots

image

image

Selectable tag

Additional Information

Link to Sketch File
WH Components / Patterns / Code are not open source but can provide an Abstract link.

Contributing Designers & Dev

Andrew Thompson (@AT-public)
Liz Judd (@elizabethsjudd)

@AT-public
Copy link
Author

@designertyler I wanted to follow up & see what additional information you might need for these contributions to make a determination on whether or not these are contributions that Carbon might accept?

@designertyler
Copy link

@AT-public This is something we'd like to see as a contribution.

There were questions from the team about the example screenshot where the checkmark is on the left and didn't seem to match the mockups.

This one follows the visual language and other components more closely, but there's no unselected state mocked up with it.
image

@AT-public
Copy link
Author

@designertyler great we will start working on this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants