-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Entry: Read-only #13
Comments
@JordanWSmith15 This makes sense to me! Thanks for the contribution. We are currently in V10's last push so we might not get to new features this week. I will also take this back to other designers for consensus in case I missed something. |
@JordanWSmith15 On second thought, loosing the underline makes the field technically a button styling, so it still looks very interact-able. We can consider loosing the background and re-align text... |
@shixiedesign That also works. That way, it becomes more of a label with data under it. We would need to consider what text overflow looks like. Would it be cut off by an ellipsis or something? |
@shixiedesign Any update on this? Are we leaning towards option 1 (keeping the line and removing the box)? |
I've done the same thing @JordanWSmith15. I made a symbol based on the text input component with the text top-aligned to where the top of the input field used to be: |
Update! @JordanWSmith15 @werdnanoslen Spec summary:
Below are some in context explorations from @laurenmrice |
Closing this issue and tracking development of component here: |
Hey @shixiedesign ! We also have this showing up in smaller panels, and would love to consider an alternative read only option as well. |
@dianatran18 I think for labels with data that are always read-only, a different component is needed, rather than an extension on the inputs. My team created this to handle your usecase: https://pages.github.ibm.com/maximo-app-framework/graphite/react/storybook/?path=/story/components-%E2%9C%93-field--field-label-placement-on-top |
Name of the component that the contributor wants to change
Text Entry
Explanation of why the contributor wants the change and thinks it's necessary
This request is to handle a text entry component that is filled, but is no longer editable.
My product has a very common use case for text that has been entered by one user and is important data for consumption, but can no longer be edited for a variety of reasons. The “Disabled” option is not viable, as the label and entered data is not accessible. Proposal is to simply remove the line at the base of the "Filled" version of the component, so that it closely matches with the Disabled component, but passes accessibility.
Box folder:
https://ibm.box.com/s/m2hv0o3plpadsttr5ss6rze7ids34co1
Contact:
Jordan Smith
jordanwsmith15
[email protected]
The text was updated successfully, but these errors were encountered: