fix(core): title string contains html ascii characters #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-charts-react ready! Built with commit 3007a84 |
|
Deploy preview for carbon-charts-vue ready! Built with commit 3007a84 |
|
Deploy preview for carbon-charts-angular ready! Built with commit 3007a84 https://deploy-preview-547--carbon-charts-angular.netlify.com |
theiliad
requested changes
Mar 30, 2020
| .append("tspan") | ||
| .text("..."); | ||
|
|
||
| // add events for displaying the tooltip with the title | ||
| const self = this; | ||
| title | ||
| .on("mouseenter", function() { | ||
| .on("mouseenter", function () { |
There was a problem hiding this comment.
Suggested change
| .on("mouseenter", function () { | |
| .on("mouseenter", function() { |
| self.services.events.dispatchEvent("show-tooltip", { | ||
| hoveredElement: title, | ||
| type: TooltipTypes.TITLE | ||
| }); | ||
| }) | ||
| .on("mouseout", function() { | ||
| .on("mouseout", function () { |
There was a problem hiding this comment.
Suggested change
| .on("mouseout", function () { | |
| .on("mouseout", function() { |
zvonimirfras
previously approved these changes
Apr 8, 2020
theiliad
requested changes
Apr 8, 2020
packages/core/demo/data/line.ts
Outdated
| @@ -22,7 +22,7 @@ export const lineData = [ | |||
| ]; | |||
|
|
|||
| export const lineOptions = { | |||
| title: "Line (discrete)", | |||
| title: "Line (discrete) - long long long long long long long long long long long long long long time format ('MMM d, hh a and 'hh a')", | |||
There was a problem hiding this comment.
we should just keep this short like before. as long as it works we're good
theiliad
approved these changes
Apr 9, 2020
zvonimirfras
approved these changes
Apr 9, 2020
theiliad
pushed a commit
to theiliad/carbon-charts
that referenced
this pull request
May 17, 2021
…-system#547) * fix(core): title string contains html ascii characters for certain symbols * update for legend and axis text * fix demo date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title strings passed into the options are HTML number encoded (apostrophes, etc -> ')
Setting to
.text()renders the string as is, setting to.html()renders the string after it is decoded. The DOM html is unaffected by the change.This bug appears in the legend (see below) and axis titles but not within the toolltip (toolltip passes the strings through
.html())Review checklist (for reviewers only)