Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vite error with Vue3 caused by package.json exports lacking a "." property (issue 1641) #1642

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Aug 5, 2023

Updates

  • When using @carbon/charts-vue in an environment with vite, an error would be displayed because the package did not an export like this:
    ".": {
      "style": "./dist/styles.css",
      "types": "./dist/index.d.ts",
      "default": "./dist/index.mjs"
    }

Closes #1641

@nstuyvesant nstuyvesant requested review from theiliad, Akshat55 and a team as code owners August 5, 2023 17:29
@nstuyvesant nstuyvesant requested review from zvonimirfras and removed request for a team August 5, 2023 17:29
@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 7297e8a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/64ce86e7dc65460009715098
😎 Deploy Preview https://deploy-preview-1642--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 7297e8a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/64ce86e7d8fb100008f6f9cc
😎 Deploy Preview https://deploy-preview-1642--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 7297e8a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/64ce86e7b01108000870c00c
😎 Deploy Preview https://deploy-preview-1642--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nstuyvesant nstuyvesant changed the title Fix vite error with Vue3 caused by package.json exports not providing ".": { default } value Fix vite error with Vue3 caused by package.json exports lacking a "." property (issue 1641) Aug 5, 2023
@theiliad theiliad merged commit e18f6f5 into carbon-design-system:master Aug 6, 2023
1 check passed
@theiliad theiliad deleted the issue-1641 branch August 6, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants