Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: ibm-simple-bar-chart modal translations #1577

Closed
msolanon opened this issue Jun 19, 2023 · 6 comments
Closed

[Enhancement]: ibm-simple-bar-chart modal translations #1577

msolanon opened this issue Jun 19, 2023 · 6 comments
Labels
severity: 2 User cannot complete task, and/or no workaround type: a11y ♿

Comments

@msolanon
Copy link

msolanon commented Jun 19, 2023

Detailed description

When we open the modal from ibm-simple-bar-chart component we are not able to translate this values (the ones that are in red).

We also checked the documentation and there is no way to send them as a parameter to the component

https://charts.carbondesignsystem.com/angular/?path=/story/simple-charts-bar-simple--vertical-simple-bar-discrete

Steps to reproduce the issue

Additional information

  • 6079a311-869e-430f-b9ac-7b890b781d2f
  • Notes
@msolanon msolanon changed the title idm-simple-bar-chart modal translation issues ibm-simple-bar-chart modal translation issues Jun 19, 2023
@Akshat55
Copy link
Collaborator

Transferring issue to carbon-charts repo as this is not a carbon angular specific issue.

@Akshat55 Akshat55 transferred this issue from carbon-design-system/carbon-components-angular Jun 24, 2023
@nstuyvesant
Copy link
Contributor

This is an enhancement request as it's not functionality that was ever implemented in the product. Only the dates are translated via date-fns.

@msolanon - could you please add "[Enhancement] " to the beginning of this issue's title?

@msolanon msolanon changed the title ibm-simple-bar-chart modal translation issues [Enhancement]: ibm-simple-bar-chart modal translations Jun 27, 2023
@theiliad
Copy link
Member

Yes I have these on my radar, and have added similar issues to the backlog, we should soon take care of this

@msolanon
Copy link
Author

Thanks @theiliad

@nstuyvesant
Copy link
Contributor

@msolanon - does this issue (#1635) address what you're running into? If so, perhaps consider closing this one so we can consolidate. Feel free to update the other issue if you'd like to see anything changed.

@msolanon
Copy link
Author

msolanon commented Aug 3, 2023

@nstuyvesant Looks like it does

@msolanon msolanon closed this as completed Aug 3, 2023
@theiliad theiliad moved this to ⏱ Backlog in @carbon/charts Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: 2 User cannot complete task, and/or no workaround type: a11y ♿
Projects
Status: ⏱ Backlog
Development

No branches or pull requests

4 participants