fix(core): keep custom fill colors if custom getIsFilled is passed #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over for line graph fix carbon-design-system#1032
Akshat55
requested review from
cal-smith and
zvonimirfras
and removed request for
a team
|
What color should the tooltip be displaying? The line or the dot fill-color? |
the datapoint still belongs to the datagroup, so the line color is fine |
theiliad
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep custom fill colors if custom getIsFilled is passed on mouseover for line graph
fix #1032
Updates
Demo screenshot or recording
Screen.Recording.2021-06-29.at.10.26.12.AM.mov
Review checklist (for reviewers only)