Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix minor bug with data values that are undefined #1007

Merged
merged 3 commits into from
Apr 29, 2021
Merged

fix(core): fix minor bug with data values that are undefined #1007

merged 3 commits into from
Apr 29, 2021

Conversation

theiliad
Copy link
Member

  • couple of small adjustments to existing code

@theiliad theiliad requested review from natashadecoste and a team as code owners April 28, 2021 21:21
@theiliad theiliad requested review from cal-smith and zvonimirfras and removed request for a team April 28, 2021 21:21
@theiliad theiliad added the type: bug 🐛 Something isn't working label Apr 28, 2021
@theiliad theiliad requested a review from sophiiae April 28, 2021 21:22
@theiliad theiliad merged commit 5c4db99 into carbon-design-system:master Apr 29, 2021
theiliad added a commit to theiliad/carbon-charts that referenced this pull request May 17, 2021
@theiliad
fix(core): fix minor bug with data values that are undefined (carbon-…
739e4d1 
…design-system#1007)

* fix(core): fix minor bug with data values that are undefined

* clearer logic

* clearer logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natashadecoste natashadecoste natashadecoste approved these changes

@cal-smith cal-smith Awaiting requested review from cal-smith

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras

@sophiiae sophiiae Awaiting requested review from sophiiae

Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theiliad @natashadecoste