Skip to content

Commit

Permalink
fix(core angular): IE11 Support
Browse files Browse the repository at this point in the history
IE11 Support
  • Loading branch information
theiliad committed Aug 31, 2018
1 parent f984d0e commit b0dd2b5
Show file tree
Hide file tree
Showing 11 changed files with 71 additions and 13 deletions.
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
<h3 align="center">Carbon Charts</h3>
<p align="center">
A reusable framework-agnostic D3 charting library.
<br /><br />
<a href="https://travis-ci.org/IBM/carbon-charts/">
<img src="https://api.travis-ci.org/IBM/carbon-charts.svg?branch=master" />
</a>
<a href="https://www.npmjs.com/package/@carbon/charts">
<img src="https://img.shields.io/npm/v/@carbon/charts.svg" />
</a>
<img src="https://img.shields.io/badge/comp-IE11%2B-blue.svg" />
</p>
<p align="center">
:bar_chart: :chart_with_upwards_trend: :rocket:
Expand Down
4 changes: 3 additions & 1 deletion packages/angular/src/charts.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import { BarChartComponent } from "./bar-chart.component";
import { LineChartComponent } from "./line-chart.component";

@NgModule({
imports: [CommonModule],
imports: [
CommonModule
],
declarations: [
DonutChartComponent,
PieChartComponent,
Expand Down
37 changes: 36 additions & 1 deletion packages/core/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"@types/d3": "4.11.0",
"@types/jasmine": "2.8.7",
"@types/node": "10.0.8",
"babel-polyfill": "^6.26.0",
"css-loader": "0.28.7",
"extract-text-webpack-plugin": "3.0.2",
"file-loader": "1.1.5",
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/bar-chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class BarChart extends BaseAxisChart {
this.updateOverlay().hide();

// Dispatch the load event
this.events.dispatchEvent(new Event("load"));
this.dispatchEvent("load");
}

interpolateValues(newData: any) {
Expand Down Expand Up @@ -173,7 +173,7 @@ export class BarChart extends BaseAxisChart {
this.updateOverlay().hide();

// Dispatch the update event
this.events.dispatchEvent(new Event("update"));
this.dispatchEvent("update");
}

updateElements(animate: boolean, rect?: any, g?: any) {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/base-axis-chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class BaseAxisChart extends BaseChart {
this.repositionXAxisTitle();
}

this.events.dispatchEvent(new Event("resize"));
this.dispatchEvent("resize");
}

/**************************************
Expand Down
10 changes: 8 additions & 2 deletions packages/core/src/base-chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,13 @@ export class BaseChart {
this.setData(configs.data);
}
}

dispatchEvent(eventType: string) {
const event = document.createEvent("Event");
event.initEvent(eventType, false, true);

this.events.dispatchEvent(event);
}

setData(data: any) {
const { selectors } = Configuration;
Expand All @@ -65,7 +71,7 @@ export class BaseChart {
const newDataIsAPromise = Promise.resolve(data) === data;

// Dispatch the update event
this.events.dispatchEvent(new Event("data-change"));
this.dispatchEvent("data-change");

if (initialDraw || newDataIsAPromise) {
this.updateOverlay().show();
Expand All @@ -78,7 +84,7 @@ export class BaseChart {

Promise.resolve(data).then(value => {
// Dispatch the update event
this.events.dispatchEvent(new Event("data-load"));
this.dispatchEvent("data-load");

// Process data
// this.data = this.dataProcessor(Tools.clone(value));
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/line-chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export class LineChart extends BaseAxisChart {
this.updateOverlay().hide();

// Dispatch the load event
this.events.dispatchEvent(new Event("load"));
this.dispatchEvent("load");
}

interpolateValues(newData: any) {
Expand Down Expand Up @@ -136,7 +136,7 @@ export class LineChart extends BaseAxisChart {
this.updateOverlay().hide();

// Dispatch the update event
this.events.dispatchEvent(new Event("update"));
this.dispatchEvent("update");
}

updateElements(animate: boolean, gLines?: any) {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/stacked-bar-chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class StackedBarChart extends BaseAxisChart {
this.updateOverlay().hide();

// Dispatch the load event
this.events.dispatchEvent(new Event("load"));
this.dispatchEvent("load");
}

interpolateValues(newData: any) {
Expand Down Expand Up @@ -159,7 +159,7 @@ export class StackedBarChart extends BaseAxisChart {
this.updateOverlay().hide();

// Dispatch the update event
this.events.dispatchEvent(new Event("update"));
this.dispatchEvent("update");
}

resizeChart() {
Expand Down
5 changes: 4 additions & 1 deletion packages/core/webpack.build.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ function rxjsExternal(context, request, cb) {
module.exports = [{
devtool: "source-map",
entry: {
charts: "./src/index.ts"
charts: [
"babel-polyfill",
"./src/index.ts"
]
},
output: {
path: __dirname + '/dist/bundle',
Expand Down
5 changes: 4 additions & 1 deletion packages/core/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ var HtmlWebpackPlugin = require('html-webpack-plugin');

module.exports = {
devtool: "sourcemap",
entry: "./demo/index.ts",
entry: [
"babel-polyfill",
"./demo/index.ts"
],
output: {
path: __dirname + '/demo/bundle',
filename: "bundle.js",
Expand Down

0 comments on commit b0dd2b5

Please sign in to comment.