Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capstone_static.vcxproj does not include mapping.c #2433

Closed
hsebs opened this issue Aug 11, 2024 · 2 comments
Closed

capstone_static.vcxproj does not include mapping.c #2433

hsebs opened this issue Aug 11, 2024 · 2 comments

Comments

@hsebs
Copy link

hsebs commented Aug 11, 2024

Work environment

Questions Answers
OS/arch/bits Debian arm 64, MacOS AArch64, MacOS x86, Windows x86 etc.
Architecture ppc, x86, cortexm, armv8 etc.
Source of Capstone git clone, brew, pip, release binaries etc.
Version/git commit v5.0.1,

Expected behavior

  • no link error with capstone_static.lib

Actual behavior

  • link errors
    • ex) LNK2001: unresolved external symbol mapping_get_op_access

Steps to reproduce the behavior

  • build capstone_static.lib and build pe file with it.

Additional Logs, screenshots, source code, configuration dump, ...

Drag and drop zip archives containing the Additional info here, don't use external services or link.
Screenshots can be directly dropped here.

hsebs added a commit to hsebs/capstone that referenced this issue Aug 11, 2024
@hsebs hsebs mentioned this issue Aug 11, 2024
2 tasks
@Rot127
Copy link
Collaborator

Rot127 commented Aug 11, 2024

We are probably going to remove those project files. Visual Studio is very much capable of generating them from the cmake files.

But for the v5 branch this is a welcome fix.

kabeor pushed a commit that referenced this issue Aug 12, 2024
@Rot127
Copy link
Collaborator

Rot127 commented Aug 16, 2024

Closes by #2434

@Rot127 Rot127 closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants