-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem with lang.json #1226
Comments
I am using laravel 6.5.2 btw |
You can fork this repository, modify file json/fr.json and send PR. Or wait for the French-speaking programmer to do this. For example, caouecs 😀 |
For Laravel 6, you don't need the line with displayableActionUrl ? It's for Laravel 7, is not it ? |
The line displayableActionUrl affected since Laravel 6.x. Please check here https://github.com/laravel/framework/blob/6.x/src/Illuminate/Notifications/resources/views/email.blade.php#L55 |
I think it's because laravel don't pass the actionURL only actionText, this is due to a commit 14 days ago File: email.blade.php @lang(
"If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\n".
'into your web browser:',
[
'actionText' => $actionText,
]
) <span class="break-all">[{{ $displayableActionUrl }}]({{ $actionUrl }})</span> |
D’ailleurs c'est copier/coller et pas copié/collé |
je dirais plutôt copiez et collez |
This line:
should be changed to:
|
I noticed the same error as you @robertgarrigos in the translation for PL, I corrected the same problem, and only now I noticed that you wrote it here;) |
Sorry for the lag So, I delete ":displayableActionUrl" everywhere ? or I do two lines ( with and without ) ? |
just delete |
done |
thx for updating all files :) |
Hello,
I am currently using the file json/fr.json from your repository.
Everything is translated, except for this line :
do you have any idea for this?
The text was updated successfully, but these errors were encountered: