Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with lang.json #1226

Closed
daltar opened this issue Mar 18, 2020 · 13 comments
Closed

problem with lang.json #1226

daltar opened this issue Mar 18, 2020 · 13 comments

Comments

@daltar
Copy link

daltar commented Mar 18, 2020

Hello,

I am currently using the file json/fr.json from your repository.
Everything is translated, except for this line :

"If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser: [:displayableActionUrl](:actionURL)": "Si vous avez des problèmes en cliquant sur le bouton \":actionText\", faites un copié/collé de l'url ci-dessous dans votre navigateur :\n [:displayableActionUrl](:actionURL)".

do you have any idea for this?

@daltar
Copy link
Author

daltar commented Mar 18, 2020

I am using laravel 6.5.2 btw

@daltar daltar changed the title problem with fr.json problem with lang.json Mar 18, 2020
@andrey-helldar
Copy link
Member

andrey-helldar commented Mar 18, 2020

You can fork this repository, modify file json/fr.json and send PR.

Or wait for the French-speaking programmer to do this. For example, caouecs 😀

@caouecs
Copy link
Member

caouecs commented Mar 27, 2020

For Laravel 6, you don't need the line with displayableActionUrl ? It's for Laravel 7, is not it ?

@idhamperdameian
Copy link
Contributor

For Laravel 6, you don't need the line with displayableActionUrl ? It's for Laravel 7, is not it ?

The line displayableActionUrl affected since Laravel 6.x. Please check here https://github.com/laravel/framework/blob/6.x/src/Illuminate/Notifications/resources/views/email.blade.php#L55

@Daniel-Mendes
Copy link

Daniel-Mendes commented Apr 16, 2020

I think it's because laravel don't pass the actionURL only actionText, this is due to a commit 14 days ago

File: email.blade.php

@lang(
    "If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\n".
    'into your web browser:',
    [
        'actionText' => $actionText,
    ]
) <span class="break-all">[{{ $displayableActionUrl }}]({{ $actionUrl }})</span>

@Daniel-Mendes
Copy link

D’ailleurs c'est copier/coller et pas copié/collé

@caouecs
Copy link
Member

caouecs commented Apr 27, 2020

je dirais plutôt copiez et collez

@robertgarrigos
Copy link
Contributor

This line:

If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser: [:displayableActionUrl](:actionURL)

should be changed to:

If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser:

@olsza
Copy link
Contributor

olsza commented May 6, 2020

This line:

If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser: [:displayableActionUrl](:actionURL)

should be changed to:

If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser:

I noticed the same error as you @robertgarrigos in the translation for PL, I corrected the same problem, and only now I noticed that you wrote it here;)

@caouecs
Copy link
Member

caouecs commented May 9, 2020

Sorry for the lag

So, I delete ":displayableActionUrl" everywhere ? or I do two lines ( with and without ) ?

@robertgarrigos
Copy link
Contributor

just delete [:displayableActionUrl](:actionURL)

@caouecs
Copy link
Member

caouecs commented May 12, 2020

done

@olsza
Copy link
Contributor

olsza commented May 13, 2020

thx for updating all files :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

7 participants