Add support for dynamic widget attributes #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting idea! In order to merge this in, it'll need to be added to every input (including checkbox, select, textarea…), as well as probably label? Also, with thorough tests. Thanks! |
Sometimes it is desirable to set widget attributes after the form is created. This makes it possible and should be fully backwards compatible.
|
Added the functionality for all remaining fields + tests. |
| @@ -306,3 +306,13 @@ exports.label = function (test) { | |||
| test.done(); | |||
| }; | |||
|
|
|||
| exports['dynamic widget attributes'] = function(test) { | |||
| var re = /autocomplete="no"/; | |||
There was a problem hiding this comment.
fyi "no" is an invalid value for this attribute, the only valid options are "on" or "off" - the test is fine tho :-)
ljharb
added a commit
that referenced
this pull request
Sep 9, 2013
Add support for dynamic widget attributes
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is desirable to set widget attributes after the form is
created. This makes it possible and should be fully backwards
compatible.