Objects Field (nested forms)

[lukeburns]

Adds an objects field that allows you to nest forms within forms.

[ljharb]

This should ideally solve #11. However, I don't think creating a new form object is the ideal solution. I'll think about this one before reviewing for style. Also, please add many many tests :-)

[lukeburns]

Above update fixes previously failing tests. Will add tests soon.

This solves #11 and allows the following behavior:

var reg_form = forms.create({
    username: fields.string({required: true}),
    password: fields.password({required: true}),
    confirm:  fields.password({
        required: true,
        validators: [validators.matchField('password')]
    }),
    personal: fields.object({
        name: fields.string({required: true, label: 'Name'}),
        email: fields.email({required: true, label: 'Email'}),
        address: fields.object({
            address1: fields.string({required: true, label: 'Address 1'}),
            address2: fields.string({label: 'Address 2'}),
            city: fields.string({required: true, label: 'City'}),
            state: fields.string({required: true, label: 'State'}),
            zip: fields.number({required: true, label: 'ZIP'})
        })
    })
});

What are your concerns?

[ljharb]

Primarily that "fields.object" doesn't feel intuitive to me. Why not just use a normal object literal?

[lukeburns]

Just following the existing design pattern. Updated to take object literals. The following works:

personal: {
    name: fields.string({required: true, label: 'Name'}),
    email: fields.email({required: true, label: 'Email'}),
}

However, keeping nested fields as an object field might make things easier in the future. For example, say I'd like to wrap a group of nested fields with a fieldset tag. I would be able to pass in additional parameters and perhaps do something like this:

personal: fields.object({
    name: fields.string({required: true, label: 'Name'}),
    email: fields.email({required: true, label: 'Email'}),
}, { 
    widget: widgets.fieldset({label: 'Personal Information'}) 
})

I think it's worth keeping. What do you think?

[ljharb]

Please always add trailing newlines to files

[faceleg]

Has progress on this feature stalled?

[lukeburns]

It's functional. Give it a shot.

[ljharb]

can you explain why this change is needed? (also it would seem simpler to do f.fields[k].bind(data[k] || ''))

[lukeburns]

Don't know. Reverting, because it works fine.

[ljharb]

I temporarily unmerged this. Posting a comment now.

[ljharb]

obj isn't actually used anywhere in this function. i assume that's not intentional?

[lukeburns]

Fundamentally, the approach is emulate the field methods. When a nested form is validated, it is treated as a field and expects it to handle two arguments: form and callback. I'm not currently using the first argument, but it can be used in the future.

[ljharb]

Would it make sense to do var form = obj || b so that we are using the passed form? Emulating the field methods isn't useful if it's not going to emulate the behavior as well.

[lukeburns]

It is useful. If we remove the first argument, it will break. If we need the form object in the future, it's there. I'm open to alternative approaches, but I think there's a certain elegance to this solution.

[ljharb]

Remerged. I'm going to let this sit in master for a bit before bumping the version and publishing.

[smebberson]

Can you use this functionality to add fieldset tags?