Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in eachSeries after 1.0.0 #883

Closed
goldfire opened this issue Aug 17, 2015 · 2 comments
Closed

Performance regression in eachSeries after 1.0.0 #883

goldfire opened this issue Aug 17, 2015 · 2 comments

Comments

@goldfire
Copy link

I've noticed that the speed of eachSeries has dropped significantly since 1.0.0. I've tested all versions since and the problem persists. I've created the following fiddles to demonstrate the issue:

1.0.0 - http://jsfiddle.net/nawojL7o/
1.4.2 - http://jsfiddle.net/pyw6tdp2/

@aearly
Copy link
Collaborator

aearly commented Aug 17, 2015

We added a nextTick between each step of iteration in eachSeries to a avoid stack overflows. We're going to remove it in 2.0, because it does impact performance, but it also does change the behaviour slightly.

@megawac
Copy link
Collaborator

megawac commented Aug 17, 2015

Closing as dupe of #696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants