Use shift instead of splice (when possible) in queue #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hargasinski
approved these changes
Jul 23, 2017
|
Thanks for the PR! The change looks good to me. |
|
👍 shift is usually an order of magnitude faster than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had some performance issues when using
async.cargowith large number of tasks (batches of 10k). Changingsplice(0, 1)toshift()improved it dramatically (for a batch of 10k it removed ~3 seconds from each batch).For some reason I wasn't able to reproduce it using an example. Maybe it depends on the memory state of the process. From a simple benchmark here you can see shift is much faster than splice (I checked on Safari, Chrome & Firefox on MacOS)