Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Oracle Version Provider #6

Open
ChrisDusyk opened this issue Oct 21, 2016 · 11 comments
Open

Support for Oracle Version Provider #6

ChrisDusyk opened this issue Oct 21, 2016 · 11 comments

Comments

@ChrisDusyk
Copy link

Are there any plans to write an Oracle Version Provider as well?

@canton7
Copy link
Owner

canton7 commented Oct 21, 2016

I don't use Oracle myself, so I'm not qualified to write one.

You can write your own easily: subclass VersionProviderBase and implement the three abstract methods to return suitable SQL. See the other providers for examples.

If you contribute it back, I'll happily include it 😄

@ChrisDusyk
Copy link
Author

Haha sounds good, I'd be happy to poke away at that. I just didn't want to duplicate work already being done!

@canton7
Copy link
Owner

canton7 commented Oct 21, 2016

Sure, thanks for checking!

@canton7
Copy link
Owner

canton7 commented Jan 5, 2017

Hi, have you had a chance to look at writing an Oracle Version Provider?

@ChrisDusyk
Copy link
Author

Yes, actually. I'm basically done it, and just trying to find some time to test it right now! Hopefully I'll have a PR ready to go next week.

@canton7
Copy link
Owner

canton7 commented Jan 6, 2017

Aha fantastic!

@canton7
Copy link
Owner

canton7 commented May 5, 2017

Hi, any news?

@brookpatten
Copy link

I have a working oracle provider I've been using if anyone is interested. One possible point of contention is I use the dotconnect oracle driver (because it has actual async support, unlike odp.net). If someone is interested I can PR it.

@canton7
Copy link
Owner

canton7 commented Sep 7, 2017

Yes please! We can call it something which indicates it uses the dotconnect driver, in case someone wants to write one which uses another driver.

@waldimen
Copy link

I implemented Oracle Provider using MangedOracleDriver, if you are intrested I can share it.

@canton7
Copy link
Owner

canton7 commented Feb 18, 2018

Please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants