Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wish: Support for nominator stashes #54

Open
TheGoldenEye opened this issue May 31, 2021 · 4 comments · Fixed by #58
Open

Wish: Support for nominator stashes #54

TheGoldenEye opened this issue May 31, 2021 · 4 comments · Fixed by #58

Comments

@TheGoldenEye
Copy link

It would be nice to be able to do the payouts for nominator stashes as well

@emostov
Copy link
Member

emostov commented Jun 3, 2021

I will plan on working on this at some point in the future - the feature will likely be quite slow though.

I would also like to add support for simply viewing pending payouts for a validator or nominator stash address.

@TheGoldenEye
Copy link
Author

Hi Zeke, thanks for the quick solution.
Unfortunately it is not quite what I wanted.
Your code determines the nominated validators of the current era and adds them to the validator list.
This is no longer valid when the nominations change (at least for the older eras).
In addition, payouts are claimed in eras for which I have no rewards (due to the inactive nominations).
The nominated validators should instead apply only per era, not in general.
Furthermore, only active nominations should be considered.

@TheGoldenEye
Copy link
Author

Example:
An account nominates 5 validators. The active nomination (in era 2344) was for JHDDYty2cU6vjWyMF2kvNK9hRMAgH9THwqvQpUzqQQs7KJr.
The output of "staking-payouts" looks like this:

2021-06-07 13:54:07 [payouts] info: The following unclaimed payouts where found: 
staking.payoutStakers(GWmJ7Wb93aDL1VcN5AW7VfzNyiRASpwaGu2zc1uNriwEj3h, 2,344)
staking.payoutStakers(G7Pg8TMoQpHDQNq27bb6CTB4uzyk2ccq7poJwQsojNbsipV, 2,344)
staking.payoutStakers(Hv8d8xLhJTTggzMCR3oUgmqCgQYuNfUu7syq7q1Lo9cAXg2, 2,344)
staking.payoutStakers(FFc4enhqqTkkwpec2HmH42fzrUGqNN3Qwu4U2aox5W2ArLx, 2,344)
staking.payoutStakers(JHDDYty2cU6vjWyMF2kvNK9hRMAgH9THwqvQpUzqQQs7KJr, 2,344)
2021-06-07 13:54:07 [payouts] info: Total of 5 unclaimed payouts.
2021-06-07 13:54:07 [payouts] info: Exiting ...

I would have expected only staking.payoutStakers(JHDDYty2cU6vjWyMF2kvNK9hRMAgH9THwqvQpUzqQQs7KJr, 2,344) to be paid out.

@emostov
Copy link
Member

emostov commented Jun 7, 2021

Yeah, I agree. Will try to make sure we only do payouts for eras when then nominator was actively backing the validator.

@emostov emostov reopened this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants