Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inherit Subiquity's ability to configure block probing timeout #822

Conversation

ogayot
Copy link
Member

@ogayot ogayot commented Sep 17, 2024

Port of canonical/subiquity#2073 to ubuntu-desktop bootstrap.

@ogayot ogayot force-pushed the timeout-configurable branch from 98f92c3 to f8738b6 Compare September 17, 2024 17:05
@ogayot ogayot marked this pull request as ready for review September 17, 2024 17:05
@ogayot
Copy link
Member Author

ogayot commented Sep 17, 2024

Looks like it's working now.

Supported commands are:

# Set the timeout back to the default value (120)
snap unset ubuntu-desktop-bootstrap block-probing-timeout

# Disable the timeout
snap set ubuntu-desktop-bootstrap block-probing-timeout=no
snap set ubuntu-desktop-bootstrap block-probing-timeout=null

# Set the timeout to a specific value
snap set ubuntu-desktop-bootstrap block-probing-timeout=240

Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've successfully built a snap and tested that setting the timeout works 👍

@d-loose d-loose changed the title Inherit Subiquity's ability to configure block probing timeout feat: Inherit Subiquity's ability to configure block probing timeout Sep 18, 2024
@d-loose d-loose merged commit 8685ac9 into canonical:snap/ubuntu-desktop-bootstrap/main Sep 18, 2024
1 check passed
@d-loose d-loose mentioned this pull request Nov 27, 2024
@ogayot ogayot deleted the timeout-configurable branch February 7, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants