Country codes now required on all language files

[matthew-hagemann]

Yao Wei reported that the fix to resolve EULA files correctly has had the unintended consequence of forcing all EULA files to need country codes which they had to add manually:

EULA_de.pdf -> EULA_de_DE.pdf

[spydon]

That is intended and as specified in the customization docs, we don't want to support multiple formats.

[matthew-hagemann]

@medicalwei thoughts?

That is intended and as specified in the customization docs, we don't want to support multiple formats.

[medicalwei]

Ah, just noticed that we have discussions here.

I'd like to confirm internally about whether we can rename the files, especially considering this is a legal document.

[medicalwei]

As for the document https://docs.google.com/document/d/10R0YOj4e8BTv6XPw9OE_y7GDy72xPqA5XP5lu0M7VbE/edit

The requirements of the language code format is not mentioned explicitly, and I did not realize that this requirement also applies to EULA files. I think the document may need to tell what language codes ubuntu-desktop-provision can use for their assets. If that's clear, I do not have much concern.

[spydon]

As for the document https://docs.google.com/document/d/10R0YOj4e8BTv6XPw9OE_y7GDy72xPqA5XP5lu0M7VbE/edit

The requirements of the language code format is not mentioned explicitly, and I did not realize that this requirement also applies to EULA files. I think the document may need to tell what language codes ubuntu-desktop-provision can use for their assets. If that's clear, I do not have much concern.

It does say "The language code format is the same as is used for slides, for example: EULA_en_US.pdf", but I can clarify it further.

[spydon]

@medicalwei I added a new section in the customization guide further detailing the language code format that is used:
https://docs.google.com/document/d/10R0YOj4e8BTv6XPw9OE_y7GDy72xPqA5XP5lu0M7VbE/edit#heading=h.2463op6ywahp