Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove insulting l10n strings #170

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: remove insulting l10n strings #170

merged 1 commit into from
Oct 12, 2023

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Oct 12, 2023

No description provided.

@github-actions github-actions bot added the l10n label Oct 12, 2023
@d-loose
Copy link
Member Author

d-loose commented Oct 12, 2023

Sorry - amended the commit to update the generated l10n files

@d-loose d-loose merged commit 05ac71c into canonical:main Oct 12, 2023
@C0rn3j
Copy link

C0rn3j commented Oct 13, 2023 •
edited
Loading

When the localizations are fixed, it'd be good to add them back as ua, as uk is for United Kingdom, ua is for Ukraine.

I was going by the country codes rather than the language codes.

@AlyoshaVasilieva
Copy link

ISO 639-1 language code for Ukrainian is uk, ISO 3166-1 alpha-2 country code for Ukraine is ua. United Kingdom is gb

@NazarTopolskyVilmate
Copy link

Why is removing Ukrainian localization entirely over vandalism a go to choice?

@esolitos
Copy link

esolitos commented Oct 13, 2023 •
edited
Loading

@NazarTopolskyVilmate I would assume that this is just a quick fix for the current vandalism issue, and the support will be re-introduced when a proper l10n is in place. 😄

Edit: As a matter of fact there's arleady a PR for it #171

@d-loose
Copy link
Member Author

d-loose commented Oct 13, 2023

We're checking translations for other languages as well and will of course restore the Ukrainian translations before the re-release!

1 similar comment
@d-loose
Copy link
Member Author

d-loose commented Oct 13, 2023

We're checking translations for other languages as well and will of course restore the Ukrainian translations before the re-release!

@d-loose d-loose deleted the translations branch October 18, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenvandine kenvandine kenvandine approved these changes

Assignees
No one assigned
Labels
l10n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@d-loose @C0rn3j @AlyoshaVasilieva @NazarTopolskyVilmate @esolitos @kenvandine