fix: The product name should come from SMBIOS 'Product Name' #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless you are LENOVO or IBM in which case they have forever put their product names in the 'Version' field instead. This fixes the default hostname being nonsensical on non-Lenovo systems. Closes: https://bugs.launchpad.net/bugs/2056167 Closes: canonical/ubuntu-desktop-installer#2394
vanvugt
force-pushed
the
fix-bogus-hostnames
branch
from
e87e205
to
56f8724
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
fix: The product name should come from SMBIOS 'Product Name'
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
fix: The product name should come from SMBIOS 'Product Name'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless you are LENOVO or IBM in which case they have forever put their product names in the 'Version' field instead.
This fixes the default hostname being nonsensical on non-Lenovo systems.
Closes: https://bugs.launchpad.net/bugs/2056167
Closes: canonical/ubuntu-desktop-installer#2394