Fix multipass_tests target on Ubuntu ARM64 (#3739) #3740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-erb
force-pushed
the
issues/3739
branch
from
d35941d to
9799d68
Compare
jason-erb
changed the title
jason-erb
changed the title
This change also ensures that all `<BACKEND>_ENABLED` definition checks occur at compile time, not run time, using #ifdef. Fixes canonical#3739 (Building target multipass_tests fails on Ubuntu ARM64)
jason-erb
force-pushed
the
issues/3739
branch
from
9799d68 to
5b34374
Compare
ricab
previously approved these changes
Nov 27, 2024
levkropp
previously approved these changes
Nov 28, 2024
This addresses a review comment for canonical#3739 (Building target multipass_tests fails on Ubuntu ARM64)
|
Thank you @jason-erb! I have transported that to our internal branch, to have CI run on it. |
|
Your commits are merged @jason-erb. Thanks again! |
|
@ricab You're welcome! Thanks for reviewing and merging. I'm in the running for a position on the Canonical Multipass team, so please feel free to put in a good word... 🙂 |
|
Thank you for your interest. Best of luck with your application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
<BACKEND>_ENABLEDdefinition checks occur at compile time, not run time, using#ifdef.Fixes #3739 (Building target multipass_tests fails on Ubuntu ARM64)
MULTI-1585