Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-5108] All dashboards in sharded cluster on one screen #457

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[DPE-5108] All dashboards in sharded cluster on one screen #457

merged 1 commit into from
Aug 26, 2024

Conversation

Gu1nness
Copy link
Contributor

Issue

In sharded cluster, it's not possible to check all replicasets at once

Solution

  • Fix dashboard code
  • Fix cluster value

@Gu1nness Gu1nness force-pushed the DPE-5108-mongo-db-vm-k-8-s-all-dashboards-in-sharded-cluster-are-availble-on-one-screen branch from 9db7296 to 2df9dfb Compare August 14, 2024 12:24
@Gu1nness
Copy link
Contributor Author

Screenshot 2024-08-16 at 10-02-44 MongoDB ReplSet Summary - 4 - Dashboards - Grafana
Screenshot 2024-08-16 at 10-02-56 MongoDB ReplSet Summary - 4 - Dashboards - Grafana
Screenshot 2024-08-16 at 10-03-24 MongoDB ReplSet Summary - 4 - Dashboards - Grafana
Screenshot 2024-08-16 at 10-03-32 MongoDB ReplSet Summary - 4 - Dashboards - Grafana
Screenshot 2024-08-16 at 10-03-40 MongoDB ReplSet Summary - 4 - Dashboards - Grafana

MiaAltieri
MiaAltieri previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, really looking forward to the demo 🤩

Some questions on the formatting, but from your screenshots the formatting looks great. So its fine not to revert the changes, only curious if those changes were purposeful or not

src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
@Gu1nness
Copy link
Contributor Author

@MiaAltieri Indeed those changes were unnecessary, I fixed it :)

MiaAltieri
MiaAltieri reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some last little things I noticed, like before they are non blocking since the screenshot looks accurate

src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
MiaAltieri
MiaAltieri previously approved these changes Aug 19, 2024
View reviewed changes
@Gu1nness Gu1nness force-pushed the DPE-5108-mongo-db-vm-k-8-s-all-dashboards-in-sharded-cluster-are-availble-on-one-screen branch 2 times, most recently from 13c30b0 to 7bbb90a Compare August 20, 2024 15:03
MiaAltieri
MiaAltieri previously approved these changes Aug 20, 2024
View reviewed changes
@Gu1nness Gu1nness force-pushed the DPE-5108-mongo-db-vm-k-8-s-all-dashboards-in-sharded-cluster-are-availble-on-one-screen branch from 7bbb90a to e76ed70 Compare August 21, 2024 12:26
@Gu1nness Gu1nness marked this pull request as draft August 21, 2024 16:12
Mehdi-Bendriss
Mehdi-Bendriss reviewed Aug 21, 2024
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Outdated Show resolved Hide resolved
@Gu1nness Gu1nness force-pushed the DPE-5108-mongo-db-vm-k-8-s-all-dashboards-in-sharded-cluster-are-availble-on-one-screen branch from e76ed70 to d8ca3c2 Compare August 22, 2024 11:00
MiaAltieri
MiaAltieri reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are still 20 occurances of service_name in the json. Should those still be there?

src/grafana_dashboards/MongoDB_ReplSet_Summary.json Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Show resolved Hide resolved
src/grafana_dashboards/MongoDB_ReplSet_Summary.json Show resolved Hide resolved
@Gu1nness Gu1nness marked this pull request as ready for review August 23, 2024 08:04
@Gu1nness
Copy link
Contributor Author

Looks like there are still 20 occurances of service_name in the json. Should those still be there?
TBH : Most of the occurences are for the definition + some variables that are used only when we activate the grafana juju application (for stuff like Node name).
I don't wat to remove panels, so I rather keep it that way were it's used, but it has only the "All" value which is possible.

@Gu1nness Gu1nness mentioned this pull request Aug 23, 2024
Merged
@Gu1nness Gu1nness changed the title [DPE-5108] All dashboards in sharded cluster are availble on one screen [DPE-5108] All dashboards in sharded cluster on one screen Aug 26, 2024
@Gu1nness Gu1nness merged commit 74fd8c4 into 6/edge Aug 26, 2024
30 checks passed
@Gu1nness Gu1nness deleted the DPE-5108-mongo-db-vm-k-8-s-all-dashboards-in-sharded-cluster-are-availble-on-one-screen branch August 26, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@MiaAltieri MiaAltieri MiaAltieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gu1nness @MiaAltieri @Mehdi-Bendriss