Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get assertions for aliased snaps #670

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix: get assertions for aliased snaps #670

merged 3 commits into from
Oct 2, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 2, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Use the snap name when getting a declaration assertion from snapd.

Unblocks canonical/snapcraft#4683
Unblocks canonical/snapcraft#4927
Unblocks canonical/charmcraft#1770
Fixes #622
(CRAFT-3259)
(CRAFT-3351)

@mr-cal mr-cal added the rebase Rebase-merge this PR label Oct 2, 2024
@mr-cal mr-cal marked this pull request as draft October 2, 2024 14:14
@mr-cal mr-cal force-pushed the work/CRAFT-3259/snap-alias branch from fe8a485 to 4c62dd4 Compare October 2, 2024 14:18
@mr-cal mr-cal changed the base branch from main to hotfix/2.0 October 2, 2024 14:18
@mr-cal mr-cal marked this pull request as ready for review October 2, 2024 14:19
@mr-cal mr-cal closed this Oct 2, 2024
@mr-cal mr-cal reopened this Oct 2, 2024
@mr-cal mr-cal force-pushed the work/CRAFT-3259/snap-alias branch from 4c62dd4 to be2108f Compare October 2, 2024 18:52
@mr-cal mr-cal requested review from lengau and dariuszd21 October 2, 2024 19:26
dariuszd21
dariuszd21 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dariuszd21
dariuszd21 reviewed Oct 2, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@mr-cal mr-cal mentioned this pull request Oct 2, 2024
Merged
3 tasks
mr-cal added 2 commits October 2, 2024 16:44
@mr-cal
build(deps): pin canonical-sphinx to 0.1.0
05cc37e 
0.2.0 introduces breaking changes.

Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
docs(changelog): add 2.0.3 release notes
08e7e84 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal mr-cal force-pushed the work/CRAFT-3259/snap-alias branch from be2108f to 08e7e84 Compare October 2, 2024 21:44
@mr-cal mr-cal merged commit 21db1d5 into hotfix/2.0 Oct 2, 2024
13 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3259/snap-alias branch October 2, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszd21 dariuszd21 dariuszd21 approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
rebase Rebase-merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inject instanced host snaps to the provider
3 participants
@mr-cal @lengau @dariuszd21