Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: only check vrs ids on certain tests #540

Merged
merged 1 commit into from
Mar 1, 2024
Merged

test: only check vrs ids on certain tests #540

merged 1 commit into from
Mar 1, 2024

Conversation

korikuzma
Copy link
Member

close #320

  • We do not need to be checking VRS IDs on every single test. This reduces to making this check in one place where ga4gh_identify function is called

@korikuzma
tests: only check vrs ids on certain tests
b1d76d5 
* We do not need to be checking VRS IDs on every single test. This
  reduces to making this check in one place where ga4gh_identify
function is called
@korikuzma korikuzma added priority:medium Medium priority test Changes to test code only labels Mar 1, 2024
@korikuzma korikuzma requested a review from wesleygoar March 1, 2024 00:53
@korikuzma korikuzma self-assigned this Mar 1, 2024
@korikuzma korikuzma changed the title tests: only check vrs ids on certain tests test: only check vrs ids on certain tests Mar 1, 2024
@korikuzma korikuzma merged commit bc36816 into main Mar 1, 2024
10 checks passed
@korikuzma korikuzma deleted the issue-320 branch March 1, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleygoar wesleygoar wesleygoar approved these changes

Assignees

@korikuzma korikuzma

Labels
priority:medium Medium priority test Changes to test code only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduce ga4gh vrs id checks in tests
2 participants
@korikuzma @wesleygoar