-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analysis: civic + moa variant analysis #439
Conversation
include summary statistics
- no_query --> transcript vars - incomplete category --> other
- add csv for files we are able to normalize
@jsstevenson if you want to review this, you can. If you don't have time, no worries. Just lmk |
@korikuzma thoughts on dotenv? I've thought about adding it elsewhere |
I like it! Especially when we have to set more than one env var for a project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the name of the all_queries file to be more reflective of what it actually is please? I know should_be_able_to_normalize_queries is kinda long but is a much more accurate description of what is in the file. Doesnt have to be that name but something that gets the point across.
Sure, I'll change to |
Awesome. Everything else looked great @korikuzma! |
@wesleygoar done |
close #287
Focuses mainly on the variants and terms we support, don't support, and whether or not we can normalize. I will fix the dependencies in #406