Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysis: civic + moa variant analysis #439

Merged
merged 32 commits into from
Jun 1, 2023
Merged

analysis: civic + moa variant analysis #439

merged 32 commits into from
Jun 1, 2023

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented May 31, 2023

close #287

Focuses mainly on the variants and terms we support, don't support, and whether or not we can normalize. I will fix the dependencies in #406

@korikuzma korikuzma added the priority:medium Medium priority label May 31, 2023
@korikuzma korikuzma added the analysis Analysis work label May 31, 2023
@korikuzma korikuzma requested a review from wesleygoar May 31, 2023 14:09
@korikuzma korikuzma self-assigned this May 31, 2023
@korikuzma
Copy link
Member Author

@jsstevenson if you want to review this, you can. If you don't have time, no worries. Just lmk

@jsstevenson
Copy link
Member

@korikuzma thoughts on dotenv? I've thought about adding it elsewhere

@korikuzma
Copy link
Member Author

@korikuzma thoughts on dotenv? I've thought about adding it elsewhere

I like it! Especially when we have to set more than one env var for a project.

Copy link

@wesleygoar wesleygoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the name of the all_queries file to be more reflective of what it actually is please? I know should_be_able_to_normalize_queries is kinda long but is a much more accurate description of what is in the file. Doesnt have to be that name but something that gets the point across.

@korikuzma
Copy link
Member Author

Can we change the name of the all_queries file to be more reflective of what it actually is please? I know should_be_able_to_normalize_queries is kinda long but is a much more accurate description of what is in the file. Doesnt have to be that name but something that gets the point across.

Sure, I'll change to should_be_able_to_normalize_queries

@wesleygoar
Copy link

Awesome. Everything else looked great @korikuzma!

@korikuzma korikuzma requested a review from wesleygoar June 1, 2023 13:25
@korikuzma
Copy link
Member Author

@wesleygoar done

@korikuzma korikuzma merged commit 4e7ede7 into main Jun 1, 2023
@korikuzma korikuzma deleted the issue-287 branch June 1, 2023 14:41
korikuzma added a commit that referenced this pull request Jun 4, 2023
korikuzma added a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Analysis work priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run analysis on CIViC + MOAlmanac data
3 participants