-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace flake8 with ruff #475
Labels
cleanup
Changes only making code cleaner & do not change how the code works nor the outputs produced
priority:medium
Medium priority
Comments
jsstevenson
added
priority:medium
Medium priority
ci/cd
Continuous integration and continuous delivery/deployment changes
labels
Jul 29, 2023
...and, as I keep reading, it looks like this should be addressed in #474 |
korikuzma
changed the title
Add style checks to GitHub Actions
Replace flake8 with ruff
Jul 29, 2023
korikuzma
added
cleanup
Changes only making code cleaner & do not change how the code works nor the outputs produced
and removed
ci/cd
Continuous integration and continuous delivery/deployment changes
labels
Jul 29, 2023
The annotation warnings we ignore in flake8. It looks like we do this in therapy but not disease/gene |
@jsstevenson this is what i have in my select = ["E", "W", "F", "ANN", "Q", "D"]
line-length = 88
ignore = ["D205", "D400", "D415", "ANN101"]
[flake8-quotes]
inline-quotes = "double"
[per-file-ignores]
"tests/*" = ["ANN001", "ANN2", "ANN102"]
"setup.py" = ["F821"]
"*__init__.py" = ["F401"] |
Merged
Merged
👍 my vote would also be to ignore |
Closed by #494. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cleanup
Changes only making code cleaner & do not change how the code works nor the outputs produced
priority:medium
Medium priority
Side note: this repo is getting pretty big -- that would make it a good candidate for Ruff imo. Not sure how flake8/etc checks feel in others' editors but flake8 alone is taking me almost 5 seconds to cover
variation/
andtests/
whereas Ruff is almost instant.The text was updated successfully, but these errors were encountered: