Skip to content

Commit

Permalink
Resolve conflict in c/c_tests/test_04_mismatchQc.sh
Browse files Browse the repository at this point in the history
  • Loading branch information
David Jones committed Jan 28, 2019
2 parents b771fa8 + 12c83fa commit 693141e
Show file tree
Hide file tree
Showing 7 changed files with 855,086 additions and 9 deletions.
5 changes: 5 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# CHANGES

## 4.2.6

* New bam file added with mini reference for cram formatting test.
* This prevents travis timeout issues where the reference area is being searched for by bamvalidate

## 4.2.5

* mismatchQC has added commandline parameter - used by default
Expand Down
9 changes: 1 addition & 8 deletions c/c_tests/test_04_mismatchQc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,39 +46,34 @@ compare_sam () {
}

#Ensure valid format produced
echo "1"
../bin/mismatchQc -i ../t/data/mismatch_test.bam | bamvalidate
if [ "$?" != "0" ];
then
echo "ERROR running ../bin/mismatchQc -i ../t/data/mismatch_test.bam. Invalid output"
exit 1;
fi

echo "2"
../bin/mismatchQc -i ../t/data/mismatch_test.bam -l 2| bamvalidate
if [ "$?" != "0" ];
then
echo "ERROR running ../bin/mismatchQc -i ../t/data/mismatch_test.bam -l 2. Invalid output with compression levels"
exit 1;
fi

echo "3"
../bin/mismatchQc -i ../t/data/mismatch_test.bam -C | bamvalidate inputformat=cram
../bin/mismatchQc -i ../t/data/mismatch_test.cram -C | bamvalidate inputformat=cram
if [ "$?" != "0" ];
then
echo "ERROR running ../bin/mismatchQc -i ../t/data/mismatch_test.bam -C. Invalid output cram compression"
exit 1;
fi

echo "4"
../bin/mismatchQc -i ../t/data/mismatch_test.bam | bamcollate2 inputformat=bam outputformat=sam collate=0 resetaux=0 > ../t/data/mismatch_test_out.sam;
if [ "$?" != "0" ];
then
echo "ERROR running ../bin/mismatchQc -i ../t/data/mismatch_test.bam | samtools view -h -o ../t/data/mismatch_test_out.sam"
exit 1;
fi

echo "5"
if [ compare_sam '../t/data/mismatch_test_out.sam' '../t/data/mismatch_expected_out.sam' != "0" ];
then
echo "ERROR in "$0": Comparing mismatchQc to expected result failed."
Expand All @@ -87,15 +82,13 @@ then
exit 1
fi

echo "6"
../bin/mismatchQc -i ../t/data/mismatch_test.bam -t 0.01 | bamcollate2 inputformat=bam outputformat=sam collate=0 resetaux=0 > ../t/data/mismatch_test_out.sam;
if [ "$?" != "0" ];
then
echo "ERROR running ../bin/mismatchQc -i ../t/data/mismatch_test.bam | samtools view -h -o ../t/data/mismatch_test_out.sam"
exit 1;
fi

echo "7"
if [ compare_sam '../t/data/mismatch_test_out.sam' '../t/data/mismatch_expected_out_low_frac.sam' != "0" ];
then
echo "ERROR in "$0": Comparing mismatchQc low fraction to expected result failed."
Expand Down
2 changes: 1 addition & 1 deletion lib/PCAP.pm
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use FindBin qw($Bin);
use File::Which qw(which);
# don't use autodie, only core perl in here

our $VERSION = '4.2.5';
our $VERSION = '4.2.6';
our @EXPORT = qw($VERSION _which);

const my $LICENSE =>
Expand Down
Binary file added t/data/mismatch_test.cram
Binary file not shown.
Binary file added t/data/mismatch_test.cram.crai
Binary file not shown.
855,078 changes: 855,078 additions & 0 deletions t/data/test.fa

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions t/data/test.fa.fai
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22 51304566 4 60 61

0 comments on commit 693141e

Please sign in to comment.