Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install python using asdf instead of gha that is not pinned #120

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Jun 10, 2024

The previous GHA python install is broken actions/setup-python#886 (comment), resulting in the failure of all our PRs and main branch (https://github.com/camunda/keycloak/actions/runs/9444163527/job/26009428403)
In order to address bug this and align this repo with our other repositories, I propose to use asdf for the python installation

@leiicamundi leiicamundi requested a review from Langleu June 10, 2024 10:25
@leiicamundi leiicamundi self-assigned this Jun 10, 2024
@leiicamundi leiicamundi added the bug Something isn't working label Jun 10, 2024
@leiicamundi leiicamundi enabled auto-merge (squash) June 10, 2024 10:25
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fails to install via asdf-install, seems like some lib is missing.

@leiicamundi
Copy link
Contributor Author

@Langleu it's fixed now, I've added the required libraries to install python and also moved the awscli installation from pip to asdf to use the v2.

@leiicamundi leiicamundi requested a review from Langleu June 11, 2024 06:42
@leiicamundi leiicamundi merged commit 366ff7e into main Jun 11, 2024
19 checks passed
@leiicamundi leiicamundi deleted the fix/python-version-broken branch June 11, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants