fix: rest connector - delete validation for field audience and update…

… element template
camunda · Dec 13, 2022 · d09047e · d09047e
1 parent 017a320
commit d09047e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 26 deletions.
diff --git a/connectors/http-json/element-templates/http-json-connector.json b/connectors/http-json/element-templates/http-json-connector.json
@@ -232,6 +232,7 @@
       "group": "authentication",
       "type": "String",
       "feel": "optional",
+      "optional": true,
       "binding": {
         "type": "zeebe:input",
         "name": "authentication.scopes"
@@ -247,6 +248,7 @@
       "group": "authentication",
       "type": "String",
       "feel": "optional",
+      "optional": true,
       "binding": {
         "type": "zeebe:input",
         "name": "authentication.audience"

diff --git a/connectors/http-json/src/main/java/io/camunda/connector/http/auth/OAuthAuthentication.java b/connectors/http-json/src/main/java/io/camunda/connector/http/auth/OAuthAuthentication.java
@@ -26,7 +26,7 @@ public class OAuthAuthentication extends Authentication {
   @NotEmpty @Secret private String oauthTokenEndpoint;
   @NotEmpty @Secret private String clientId;
   @NotEmpty @Secret private String clientSecret;
-  @NotEmpty @Secret private String audience;
+  @Secret private String audience;
   @NotEmpty private String clientAuthentication;
 
   private String scopes;

diff --git a/...s/http-json/src/test/resources/requests/fail-cases-request-witout-one-requered-field.json b/...s/http-json/src/test/resources/requests/fail-cases-request-witout-one-requered-field.json
@@ -222,31 +222,6 @@
       }
     }
   },
-  {
-    "descriptionOfTest": "oauth request without audience",
-    "method": "post",
-    "url": "https://abc/def",
-    "connectionTimeoutInSeconds": "30",
-    "headers": {
-      "X-Camunda-Cluster-ID": "abcdef",
-      "User-Agent": "http-connector-demo"
-    },
-    "authentication":{
-      "oauthTokenEndpoint":"https://abc.eu.auth0.com/api/v2/",
-      "scopes": "read:clients",
-      "clientId":"secrets.CLIENT_ID",
-      "clientSecret":"secrets.CLIENT_SECRET",
-      "type":"oauth-client-credentials-flow",
-      "clientAuthentication":"basicAuthHeader"
-    },
-    "body": {
-      "customer": {
-        "id": 1231231,
-        "name": "Jane Doe",
-        "email": "[email protected]"
-      }
-    }
-  },
   {
     "descriptionOfTest": "oauth request without client authentication",
     "method": "post",