Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Timer triggering from general stream processing #4931

Closed
ChrisKujawa opened this issue Jul 9, 2020 · 4 comments
Closed

Decouple Timer triggering from general stream processing #4931

ChrisKujawa opened this issue Jul 9, 2020 · 4 comments
Labels
area/performance Marks an issue as performance related kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog

Comments

@ChrisKujawa
Copy link
Member

ChrisKujawa commented Jul 9, 2020

Description

Found at the Chaos day https://github.com/zeebe-io/zeebe-chaos/edit/master/chaos-days/2020-07-09/summary.md

We currently have the issue that we trigger timers in the same actor as the stream processing runs. This means we interrupt the normal processing to write new commands. This should be decoupled to streamline the processing. I can imagine that we can trigger the timers and also other things like timeout jobs, in a separate actor, which then writes to the dispatcher.

This would mean the stream processor can just continue with consuming new records. I think this will make the throughput more stable in case we have more timers. This cam also be done for jobs or messages etc.

@ChrisKujawa ChrisKujawa added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog area/performance Marks an issue as performance related labels Jul 9, 2020
@ChrisKujawa ChrisKujawa changed the title Decouple Timer triggering from general stream processing. Decouple Timer triggering from general stream processing Jul 9, 2020
@npepinpe
Copy link
Member

npepinpe commented Feb 2, 2021

Duplicate of #4783

@ChrisKujawa
Copy link
Member Author

Wouldn't say this is a duplicate

@npepinpe
Copy link
Member

npepinpe commented Feb 2, 2021

Fair enough, let's talk about it in the morning

@npepinpe
Copy link
Member

npepinpe commented Feb 4, 2021

Alright, so from my pov they're duplicate as they describe the same issue but propose a different approach: triggering timers can potentially slow down stream processing. Maybe you can elaborate what the other issue isn't covering, or how it's different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Marks an issue as performance related kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Development

No branches or pull requests

2 participants