Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of the navigation bar #669 and #708 #719

Closed
wants to merge 9 commits into from

Conversation

NgweBecky
Copy link

@NgweBecky NgweBecky commented Mar 10, 2024

Summary

Ensure that the signup and feedback buttons are positiones on the top right of the navigatin barin all pages, to improve consistency.
Enhance the design of the footer in the landing, slide, info and signup pages. Adds a function to get the current year and display in footer without the develop efforts to manually change year all the time.
Screenshot (37)

Screenshot (38)

Motivation

This updates the design of navigation bar of issue #669
Enhancement of footer section #708

Testing

Yes it is tested and works as expected

@NgweBecky NgweBecky changed the title update of the navigation bar #669 update of the navigation bar #669 and #708 Mar 11, 2024
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not in love with the giant footer. It's a reasonable contribution anyway, and I appreciate it even though I don't think I'll merge this one.

@birm birm closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants