-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rewrite of menu component #976
Conversation
Hey @Trancever, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
Thanks so much for the quick fix. So what should I do to do it properly? Thanks. |
I'm facing this too. How long so we get the merge? |
@Trancever If you have the time, #977 might be related. Thank you for your work fixing this bug! |
@mihaidaviddev I am aware of this issue and yes, this PR will fix it. |
@cltsang With this PR, passing padding in style will be supported. |
Thank you so much! |
I am so sorry for leaving #485 open for a long time. |
Thanks for your work @iyadthayyil ! |
@iyadthayyil Without your work, it wouldn't be possible, thanks! |
Motivation
Menu was broken on iOS, implementation was really complex and animations didn't use native driver.
Test plan