Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite of menu component #976

Merged
merged 7 commits into from
Apr 9, 2019
Merged

fix: rewrite of menu component #976

merged 7 commits into from
Apr 9, 2019

Conversation

Trancever
Copy link
Contributor

Motivation

Menu was broken on iOS, implementation was really complex and animations didn't use native driver.

Test plan

Example

@callstack-bot
Copy link

callstack-bot commented Apr 4, 2019

Hey @Trancever, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@cltsang
Copy link

cltsang commented Apr 4, 2019

Thanks so much for the quick fix.
I'd like to make a dropdown menu like the one in the material design doc. Normally the menu should be anchored to the overflow button right?
By default, the menu is rendered covering the anchor, like in your gif. So I added marginTop 40 to the menu component's style. However, the margin part does not respond to touch to dismiss the menu.
It seems the absolute fill under it does not receive the touch event. Maybe because the menu's margin is wrapped by another view, and it captures the touch event?

So what should I do to do it properly? Thanks.

@zerobytes
Copy link

I'm facing this too. How long so we get the merge?

@mihaidaviddev
Copy link

@Trancever If you have the time, #977 might be related. Thank you for your work fixing this bug!

@Trancever
Copy link
Contributor Author

@mihaidaviddev I am aware of this issue and yes, this PR will fix it.

@Trancever
Copy link
Contributor Author

@cltsang With this PR, passing padding in style will be supported.

@cltsang
Copy link

cltsang commented Apr 5, 2019

Thank you so much!

@Trancever Trancever merged commit cf6cc3d into master Apr 9, 2019
@Trancever Trancever deleted the feat/menu branch April 9, 2019 14:06
@iyadthayyil
Copy link
Contributor

I am so sorry for leaving #485 open for a long time.
I couldn't do any development in past few months.
Thanks @waquidvp
Thank you very much @Trancever for making it perfect!

@ferrannp
Copy link
Collaborator

Thanks for your work @iyadthayyil !

@Trancever
Copy link
Contributor Author

@iyadthayyil Without your work, it wouldn't be possible, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants