Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose new props to add custom color in Chip component #729

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

lukewalczak
Copy link
Member

Summary: This PR will add two new props to customize color of Chip component

screenshot 2019-01-14 at 16 04 49

Motivation

Issue no #725

@ferrannp ferrannp added the wip label Jan 31, 2019
@lukewalczak lukewalczak force-pushed the feat/custom-selected-chip-color branch from 0f25e04 to 726ce91 Compare February 6, 2019 17:49
@callstack-bot
Copy link

callstack-bot commented Feb 6, 2019

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@ferrannp ferrannp removed the blocked label Feb 21, 2019
src/components/Chip.js Outdated Show resolved Hide resolved
src/components/Chip.js Outdated Show resolved Hide resolved
src/components/Chip.js Outdated Show resolved Hide resolved
src/components/Chip.js Outdated Show resolved Hide resolved
@ferrannp
Copy link
Collaborator

Can someone else take a look at this?

@lukewalczak
Copy link
Member Author

Working on that

Summary: This PR will add two new props to customize color of Chip component
@lukewalczak lukewalczak force-pushed the feat/custom-selected-chip-color branch from 726ce91 to be415cb Compare March 15, 2019 09:53
@Trancever Trancever removed the wip label Mar 15, 2019
@Trancever Trancever merged commit 4a28c3e into master Mar 15, 2019
@Trancever Trancever deleted the feat/custom-selected-chip-color branch March 15, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants