Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated use of defaultProps #4385

Merged
merged 1 commit into from
Jul 27, 2024
Merged

fix: remove deprecated use of defaultProps #4385

merged 1 commit into from
Jul 27, 2024

Conversation

timbocole
Copy link
Contributor

Motivation

This PR prevents the error log warning the "defaultProps" will be removed (visible in RN0.74.0)

Related issue

Addresses #4382

Test plan

Ensure that use of the TextInputIcon does not produce the error (included in linked issue) when run using RN0.74.0

@callstack-bot
Copy link

Hey @timbocole, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@timbocole timbocole changed the title fix: remove deprected use of defaultProps fix: remove deprecated use of defaultProps Apr 26, 2024
@gedu gedu added this to the 5.12.4 milestone Apr 26, 2024
@gedu
Copy link
Contributor

gedu commented Apr 27, 2024

LGTM, This will be on version 5.12.4

Copy link

@sethimcclaine sethimcclaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves bug report #4402 for me. Thank you!

@rodrigoAbril
Copy link

Hi @gedu @sethimcclaine any Idea when is 5.12.4 scheduled for?

@nickba86
Copy link

Hi all!! Thanks for the work!. So I shall wait until the next release ? and ignore the error message? Thanks!!!!!

@gedu
Copy link
Contributor

gedu commented May 17, 2024

Hi @gedu @sethimcclaine any Idea when is 5.12.4 scheduled for?

Hey, we are trying to upgrade paper to support almost latest RN version, and after that we will submit it, I hope as soon as possible

Copy link

@kaustubh57 kaustubh57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for removing default props.

@nazaruha
Copy link

nazaruha commented Jun 7, 2024

on RN 0.74.2 I get a warning with this problem.

@josiahgerald
Copy link

Is there any update with this PR?

@itosinu
Copy link

itosinu commented Jul 2, 2024

When it will be released to main?

@gedu
Copy link
Contributor

gedu commented Jul 2, 2024

The main maintainer of the library has been really busy these past days. I would like him to perform a final check on all the open PRs that will be merged for Milestone 5.12.4. Hope it will be soon

@AstronautJoe
Copy link

merge pleeease

@LuisDanilo
Copy link

merge please 🙏

@Loschcode
Copy link

Following the tradition of asking for a merge, could you please merge that one? 😆

@jerrywonderr
Copy link

How do I follow this pull request to know when it gets merged?

@itosinu
Copy link

itosinu commented Jul 17, 2024

Why don't merge this PR? Many of people is waiting to be approved.

@h3d0
Copy link

h3d0 commented Jul 19, 2024

Merge the change finally. This isn't a breaking change or something, there are no reasons to keep this for months.

@lukewalczak lukewalczak merged commit 4b2052a into callstack:main Jul 27, 2024
3 checks passed
@maiznadeem
Copy link

Merge the change finally. This isn't a breaking change or something, there are no reasons to keep this for months.

No way. The code broke. Is this because of that change?

@raajnadar
Copy link
Collaborator

This broke the update - https://github.com/callstack/react-native-paper/pull/4422/files

Also, there is a PR that will fix it - #4466

Mostly will be available in the next release

@timbocole
Copy link
Contributor Author

I was about to say, not sure how this PR could be at fault! 😂 - Thanks @raajnadar for the update/fix.

@mauricionuup
Copy link

This issue also affects version 4. What would be the best way to take this fix to that version as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.