fix: allow pass-through of accessibilityRole prop on Button.tsx #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @meatnordrink, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
reviewed
Nov 28, 2023
|
Hey @meatnordrink, could you please resolve the conflict? |
Co-authored-by: Luke Walczak <[email protected]>
lukewalczak
reviewed
Jan 8, 2024
lukewalczak
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In cases where a button is used because it is stylistically desired, but the
onPressevent opens a link, we should be able to set theaccessibilityRoleof the button aslinkfor screen readers. Otherwise, it should remainbuttonby default.The inclusion of an icon or styling can indicate link behavior to a sighted user, but is not detectable by a screen reader.
Test plan
accessibilityRole='link'as a prop to a button, and navigate to the button via screen reader. It should announce as a link.accessibilityRoleprop, and navigate to the button via screen reader; it should announce as a button.I have tested this locally, and it works as expected.