fix: adjust progress bar wrapper height on web #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here. |
tjaniczek
reviewed
Jul 25, 2023
| @@ -59,3 +59,13 @@ it('renders indeterminate progress bar', async () => { | |||
|
|
|||
| expect(tree.toJSON()).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| it('renders progress bar with full height on web', () => { | |||
| Platform.OS = 'web'; | |||
There was a problem hiding this comment.
Wouldn't that affect every test from now on in this file?
tjaniczek
reviewed
Jul 25, 2023
| @@ -94,11 +94,23 @@ const ProgressBarExample = () => { | |||
| <View style={styles.row}> | |||
| <Text variant="bodyMedium">ProgressBar with animated value</Text> | |||
| <AnimatedProgressBar | |||
| visible={visible} | |||
tjaniczek
approved these changes
Jul 25, 2023
lukewalczak
force-pushed
the
fix/web-progress-bar-percentage-height
branch
from
8208f26 to
64488a8
Compare
tjaniczek
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3984
Summary
Correct view wrapper styles for the web to properly display
ProgressBarwith the percentage height.Test plan
Added new example and unit test case.