Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove conditional React Navigation 7 support #3958

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

tjaniczek
Copy link
Collaborator

@tjaniczek tjaniczek commented Jun 27, 2023

Summary

Experimental integration with React Navigation 7 throws warnings in Webpack. Since RN7 is scheduled to release in September, for now we'll remove the integration. This will give us time to find better solution

Test plan

Unit tests pass, example app works with RN6

Fixes: #3952

@callstack-bot
Copy link

Hey @tjaniczek, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here.

@lukewalczak lukewalczak added this to the 5.9.0 milestone Jun 28, 2023
@lukewalczak lukewalczak added the dependencies Pull requests that update a dependency file label Jun 28, 2023
@lukewalczak lukewalczak merged commit 2235fde into main Jun 28, 2023
@lukewalczak lukewalczak deleted the fix/revert-react-navigation-7 branch June 28, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export 'useLinkTools' (imported as 'useLinkTools') was not found in '@react-navigation/native'
3 participants