Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add long press support for fab group #3881

Merged
merged 3 commits into from
May 15, 2023

Conversation

Q1w1N
Copy link
Contributor

@Q1w1N Q1w1N commented May 10, 2023

Summary

Added onLongPress support. Allows to revert the logic of displaying actions stack from onPress to onLongPress.

Related issue:

#3180

Test plan

  • Check if long press triggers action, and single press toggles stack.
  • Open actions stack by press.
  • Click "Toggle on Long Press" action.
  • Check if logic got reverted, and now single press triggers action, and long press toggles stack.

@Q1w1N Q1w1N added the FAB label May 10, 2023
@Q1w1N Q1w1N requested review from gedu and lukewalczak May 10, 2023 17:05
@Q1w1N Q1w1N changed the title feat: added long press support for fab group feat: add long press support for fab group May 10, 2023
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here.

@callstack-bot
Copy link

callstack-bot commented May 12, 2023

Hey @kwereszczynski, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak merged commit 92c4037 into main May 15, 2023
@lukewalczak lukewalczak deleted the feat/fab-group-long-press-support branch May 15, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants